Feat/mobile button - #766
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74a48be747
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dddff76450
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 756c6ba22e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd88d3498d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
TorinAsakura
left a comment
TorinAsakura
left a comment
There was a problem hiding this comment.
Пара вопросов по соседнему архитектурному контуру. Текущий PR они не блокируют.
-
Button теперь берёт расстояние между содержимым и дополнениями из
ButtonShape.gapи не вызываетAddon.Spacer(), тогда как Input и TextListItem продолжают исполнятьSpacer(). Какой контракт для общегоAddonсчитаем целевым и кто должен владеть этим расстоянием? -
DropShadowClipping,DropShadowIsolationиShadowConversionиспользуются толькоModifier.elevation, но размещены в общемprimitives.utils. Какой владелец предполагается у этого пакета и какие ещё примитивы должны его использовать?
2 participants
Таска
Как проверять
ButtonДействие: переключить appearance, size, dark theme, Focused, Enabled и Icons; нажать кнопки для проверки Pressed.
Ожидаемый результат: цвета, формы, отступы, центрирование, состояния и тени соответствуют Figma; у Ghost фон остаётся прозрачным, у полупрозрачных кнопок тень не просвечивает внутри формы.
Пруфы
Details
Screen_recording_20260825_012813.mp4